andygrove commented on code in PR #2474: URL: https://github.com/apache/datafusion-ballista/pull/2474#discussion_r4076127471
########## .gitignore: ########## @@ -18,71 +18,28 @@ apache-rat-*.jar rat.txt filtered_rat.txt -arrow-src.tar -arrow-src.tar.gz CHANGELOG.md.bak Cargo.toml.bak data/ # Compiled source -*.a -*.dll -*.o *.py[ocd] -*.so -*.so.* -*.bundle -*.dylib -.build_cache_dir -dependency-reduced-pom.xml -MANIFEST -compile_commands.json -build.ninja -# Generated Visual Studio files -*.vcxproj -*.vcxproj.* -*.sln *.iml -# Linux perf sample data -perf.data Review Comment: Small nit, feel free to ignore. `perf.data` isn't really Arrow specific and folks do run `perf` against the executor, so it might be worth keeping. ########## docs/source/contributors-guide/development.md: ########## @@ -202,6 +202,13 @@ A release branch therefore only ever depends on published crates. Each `rev` bum that ports any DataFusion API changes, refreshes affected golden files, and keeps `cargo test` and `cargo clippy --all-targets --workspace -- -D warnings` green. +`dev/update_datafusion_versions.py` rewrites the `datafusion*` entries across the workspace for you. Review Comment: I tried this on a clean checkout of main (`uv run --no-project --with tomlkit dev/update_datafusion_versions.py 56.0.0`) and it only changed `python/Cargo.toml` and `python/pyproject.toml`. The real pins live in `[workspace.dependencies]` in the root `Cargo.toml`, and the member crates all use `workspace = true`, so the script skips them. Its `crates` list is also still the upstream DataFusion one (`datafusion-jit`, `datafusion-row`, and so on) and is missing `datafusion-spark`, `datafusion-substrait`, `datafusion-proto-common` and `datafusion-functions-aggregate-common`. Could we either leave this doc out of this PR, or fix the script to update the root manifest first? Happy to see that as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
