dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4048085990
##########
dev/ci/compute-changes.py:
##########
@@ -387,6 +387,26 @@
".mvn/**",
"mvnw",
],
+ "delta": [
Review Comment:
> Could you put the measured runner-minutes in the description? If it lands
where I think it does, it may be worth trimming to one Spark profile in the
queue with the other two on the label or nightly
Trimmed in e320d96f5 to the Iceberg shape: Spark 3.5 runs in the queue, 4.0
and 4.1 run nightly, and `run-delta-tests` opts a pull request into all three.
The reusable workflow takes the profile as an input, and the MinIO, feature-off
and dev-script jobs run once, on the 3.5 call. Measured minutes have to come
from the labelled run, since the suites have not executed in CI on this PR yet;
your 8m6s of test time for the 3.5 leg matches what I see locally for the three
suites, and I will put the runner minutes in the description once that run
exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
