dwsmith1983 commented on code in PR #5365: URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4081163000
########## spark/pom.xml: ########## @@ -222,6 +222,27 @@ under the License. </dependencies> <profiles> + <profile> + <!-- Only the contrib build needs the test-jar: contrib/delta-spark reuses CometTestBase + and the shared test utilities in its suites. Binding it here keeps the jar out of + every other profile's install and out of the release upload. --> + <id>delta</id> Review Comment: > Please activate `delta` for the prerequisite installs and the README's matching command, or use a build sequence that produces the current test JAR. Done on 15 September. Both prerequisite installs in `delta_contrib_test.yml` and the README's first command run with `-Pspark-X,delta`, so the install produces this checkout's test jar before the contrib suites resolve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
