andygrove commented on code in PR #5852:
URL: https://github.com/apache/datafusion-comet/pull/5852#discussion_r3997199008
##########
.github/workflows/pr_build_linux.yml:
##########
@@ -119,6 +119,9 @@ jobs:
restore-keys: |
${{ runner.os }}-java-maven-
+ - name: Bootstrap Maven
+ uses: ./.github/actions/maven-bootstrap
Review Comment:
Good catch — fixed. Added `.github/actions/maven-bootstrap/**` to
`FILTERS['build_linux']` and pinned it with a routing case in
`check-ci-config.py`:
```python
# The Maven bootstrap composite is called only from pr_build_linux.yml.
([".github/actions/maven-bootstrap/action.yaml"], {"build_linux"}),
```
With that file as the only change, `EVENT_NAME=pull_request
compute-changes.py` now reports `build_linux=true` and everything else `false`.
I checked the routing case actually bites by deleting the filter line again —
`check-ci-config.py` fails with exactly your finding.
On the red `[expressions]` jobs: those are #5610's `CometCodegenSuite`
decimal-promotion breakage, fixed on main by #5849 after this branch's base.
I've rebased, so the re-run should be clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
