sunchao commented on code in PR #5852:
URL: https://github.com/apache/datafusion-comet/pull/5852#discussion_r3985810040
##########
.github/workflows/pr_build_linux.yml:
##########
@@ -119,6 +119,9 @@ jobs:
restore-keys: |
${{ runner.os }}-java-maven-
+ - name: Bootstrap Maven
+ uses: ./.github/actions/maven-bootstrap
Review Comment:
### Correctness
[P2] Route changes to the new bootstrap action into Linux CI
Could you add `.github/actions/maven-bootstrap/**` to
`FILTERS['build_linux']` in `dev/ci/compute-changes.py` and add a routing case
in `dev/ci/check-ci-config.py`? With only
`.github/actions/maven-bootstrap/action.yaml` as input, the current filter
returns `build_linux=false`. The `ci.yml` gate then skips the entire Linux
workflow, including all five consumers of this new action, so an action-only
change can pass preflight without exercising the bootstrap. This PR's CI run
does not expose the gap because the accompanying edit to `pr_build_linux.yml`
makes the filter true. [Filter at the reviewed
head](https://github.com/apache/datafusion-comet/blob/ef823b74d6159fba8f92bb7ea71958dea54e66df/dev/ci/compute-changes.py#L29-L52).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
