HairstonE commented on PR #23871: URL: https://github.com/apache/datafusion/pull/23871#issuecomment-5079145882
I think just the guard is best here. It is simple and doesn't impact common queries. I believe queries where every GROUP BY expression is a constant and there is an aggregate are the only ones impacted. ```` SELECT avg(v1) FROM t1 GROUP BY false; -- issue reproducer ```` These more common queries are **not** impacted. ```` SELECT region, sum(sales) FROM t GROUP BY region; SELECT region, 'Q1', sum(sales) FROM t GROUP BY region, 'Q1'; SELECT sum(v1) FROM t; ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
