HairstonE commented on PR #23871:
URL: https://github.com/apache/datafusion/pull/23871#issuecomment-5074268882

   I can reopen that PR. Right now it is not what Neil is suggesting, I would 
need to revert
     a commit back for the "decline to optimize away the grouping if all of the 
grouping
     expressions are constants" guard. If we go with the version currently on 
that branch I still need
     to address previous review comments before I closed it (unneeded cloning 
and possibly the
     registry lookup).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to