neilconway commented on PR #23871: URL: https://github.com/apache/datafusion/pull/23871#issuecomment-5074287819
> I can reopen that PR. Right now it is not what Neil is suggesting, I would need to revert a commit back for the "decline to optimize away the grouping if all of the grouping expressions are constants" guard. Personally I'd prefer that simple approach, but if anyone (e.g., you or @alamb) see a reason to do something more complicated, would love to discuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
