2010YOUY01 commented on code in PR #23078:
URL: https://github.com/apache/datafusion/pull/23078#discussion_r3458282642
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -6610,6 +6611,63 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_swap_inputs_clears_dynamic_filter() -> Result<()> {
Review Comment:
Yes I agree, adding custom rule is quite tricky.
There are lots of implicit assumptions like 'rule A must be run after rule
B', so if your extension rule might require certain properties, it's a good
idea to add more tests and assertion guards to DataFusion core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
