haohuaijin commented on code in PR #23078:
URL: https://github.com/apache/datafusion/pull/23078#discussion_r3456625871
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -6610,6 +6611,63 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_swap_inputs_clears_dynamic_filter() -> Result<()> {
Review Comment:
I opened a separate issue to discuss the broader public API contract of
`HashJoinExec::swap_inputs()` for downstream optimizer usage: #23105
For this PR, should we keep it scoped to making `swap_inputs()` drop the
stale dynamic filter and documenting that behavior, or would you prefer this PR
only add an assertion/precondition for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
