2010YOUY01 commented on code in PR #23078:
URL: https://github.com/apache/datafusion/pull/23078#discussion_r3456455131
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -6610,6 +6611,63 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_swap_inputs_clears_dynamic_filter() -> Result<()> {
Review Comment:
Could we add an end-to-end test that explains why this behavior is desired —
that `swap_inputs()` should drop the dynamic filter? It’s a bit hard to infer
the test goal from this unit test alone.
It should be some SQL queries that used to have bug in results, but
enforcing this fix make them correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
