zhuqi-lucas commented on code in PR #21956:
URL: https://github.com/apache/datafusion/pull/21956#discussion_r3246103116
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -482,6 +485,107 @@ impl ParquetSource {
pub(crate) fn reverse_row_groups(&self) -> bool {
self.reverse_row_groups
}
+
+ /// Extract the (column name, descending) tuple used by file-level
+ /// reordering. Driven entirely from the sort-pushdown channel
+ /// (`sort_order_for_reorder` + `reverse_row_groups`) — set by
+ /// `try_pushdown_sort`. We do not consult any dynamic-filter
+ /// metadata here: `DynamicFilterPhysicalExpr` is for runtime
+ /// threshold pruning, not for telling the source how to schedule
+ /// reads.
Review Comment:
Yes, will update the comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
