zhuqi-lucas commented on PR #21956: URL: https://github.com/apache/datafusion/pull/21956#issuecomment-4457183435
> Some nits: > > 1. I still think those traits should go. > 2. Several references to overheads that don't really make sense to me. Are those justified by benchmarks? Yes, those changes are from previous benchmark regression, but i am not sure if it's noise, we can trigger benchmark again, i will address it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
