github-actions[bot] commented on PR #21637: URL: https://github.com/apache/datafusion/pull/21637#issuecomment-4394375026
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-datasource-parquet v53.1.0 (current) Built [ 43.029s] (current) Parsing datafusion-datasource-parquet v53.1.0 (current) Parsed [ 0.026s] (current) Building datafusion-datasource-parquet v53.1.0 (baseline) Built [ 42.813s] (baseline) Parsing datafusion-datasource-parquet v53.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-datasource-parquet v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.142s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/auto_trait_impl_removed.ron Failed in: type ParquetFileMetrics is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/metrics.rs:31 type ParquetFileMetrics is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/metrics.rs:31 --- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field --- Description: A struct constructible with a struct literal has a new non-public field. It can no longer be constructed using a struct literal outside of its crate. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_private_field.ron Failed in: field ParquetFileMetrics.page_index_pages_skipped_by_fully_matched in /home/runner/work/datafusion/datafusion/datafusion/datasource-parquet/src/metrics.rs:75 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 88.643s] datafusion-datasource-parquet Building datafusion-physical-expr-common v53.1.0 (current) Built [ 20.482s] (current) Parsing datafusion-physical-expr-common v53.1.0 (current) Parsed [ 0.020s] (current) Building datafusion-physical-expr-common v53.1.0 (baseline) Built [ 20.210s] (baseline) Parsing datafusion-physical-expr-common v53.1.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-physical-expr-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.196s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 42.486s] datafusion-physical-expr-common Building datafusion-sqllogictest v53.1.0 (current) Built [ 136.503s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 135.436s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.085s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 277.236s] datafusion-sqllogictest ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
