xudong963 commented on PR #21637: URL: https://github.com/apache/datafusion/pull/21637#issuecomment-4385334800
@alamb thanks for the review, before getting the PR in, I think it's better to have your look for the comment https://github.com/apache/datafusion/pull/21637#discussion_r3156327107, and it's fix commit: https://github.com/apache/datafusion/pull/21637/commits/da7db27a6b51345991d67907b9985a0d67224153 (this is the lowest cost way I found to fix the metric. Let me know if you have other thoughts) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
