gene-bordegaray commented on code in PR #22002:
URL: https://github.com/apache/datafusion/pull/22002#discussion_r3178380341
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -289,6 +296,83 @@ impl DynamicFilterPhysicalExpr {
Ok(())
}
+ /// Update this filter with a global fallback plus partition-local filters.
+ pub fn update_partitioned(
Review Comment:
these are public API changes I don't love and ideally with the work being
done by @adriangb in PRs like #21931 we can have this be hidden from the user
and only an internal implementation detail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
