gene-bordegaray opened a new pull request, #22002:
URL: https://github.com/apache/datafusion/pull/22002
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Does not close an issue. WIP POC for discussion around #21207.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This is a proof of concept for representing file/range partitioning
truthfully instead of advertising it as hash partitioning. The goal is to show
how explicit partition compatibility can support partition-local optimizations
such as tighter dynamic filters while preserving safe fallback behavior.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Adds a custom physical partitioning trait and range partitioning
implementation.
- Lets file scans advertise range partitioning for compatible file groups.
- Adds partitioning compatibility checks separate from distribution
satisfaction.
- Routes dynamic filters by partition index when partition maps are
compatible, with hash/global fallbacks otherwise.
- Adds proto roundtrip support and end-to-end SLT coverage for
partition-local dynamic filter pruning.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. Ran:
- `cargo test -p datafusion-physical-expr -p datafusion-datasource -p
datafusion-datasource-parquet -p datafusion-physical-plan -p
datafusion-physical-optimizer -p datafusion-proto`
- `cargo test --test sqllogictests -- preserve_file_partitioning
push_down_filter_regression repartition_scan listing_table_partitions aggregate
group_by joins`
- `cargo test --test sqllogictests -- preserve_file_partitioning` after
autosquash
Touched-package clippy passed earlier. Full workspace clippy with
`--all-features` currently hits the existing benchmark allocator feature
conflict between `snmalloc` and `mimalloc`.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Yes. This POC intentionally explores public physical-plan API surface:
`Partitioning::Custom`, `PhysicalPartitioning`, `RangePartitioning`, range
bounds, and partitioning compatibility. If this direction moves beyond POC, the
PR should be treated as an API change and refined before merge.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
