github-actions[bot] commented on PR #22002: URL: https://github.com/apache/datafusion/pull/22002#issuecomment-4366585108
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning origin/main Building datafusion-datasource v53.1.0 (current) Built [ 36.127s] (current) Parsing datafusion-datasource v53.1.0 (current) Parsed [ 0.029s] (current) Building datafusion-datasource v53.1.0 (baseline) Built [ 35.827s] (baseline) Parsing datafusion-datasource v53.1.0 (baseline) Parsed [ 0.029s] (baseline) Checking datafusion-datasource v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.267s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 73.516s] datafusion-datasource Building datafusion-datasource-parquet v53.1.0 (current) Built [ 41.464s] (current) Parsing datafusion-datasource-parquet v53.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-datasource-parquet v53.1.0 (baseline) Built [ 41.488s] (baseline) Parsing datafusion-datasource-parquet v53.1.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion-datasource-parquet v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.137s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 84.586s] datafusion-datasource-parquet Building datafusion-ffi v53.1.0 (current) Built [ 55.945s] (current) Parsing datafusion-ffi v53.1.0 (current) Parsed [ 0.053s] (current) Building datafusion-ffi v53.1.0 (baseline) Built [ 55.550s] (baseline) Parsing datafusion-ffi v53.1.0 (baseline) Parsed [ 0.056s] (baseline) Checking datafusion-ffi v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.222s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 113.494s] datafusion-ffi Building datafusion-physical-expr v53.1.0 (current) Built [ 23.979s] (current) Parsing datafusion-physical-expr v53.1.0 (current) Parsed [ 0.043s] (current) Building datafusion-physical-expr v53.1.0 (baseline) Built [ 24.271s] (baseline) Parsing datafusion-physical-expr v53.1.0 (baseline) Parsed [ 0.043s] (baseline) Checking datafusion-physical-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.306s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field Inner.partitioned_exprs in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/expressions/dynamic_filters.rs:101 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron Failed in: variant Partitioning:Custom in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/partitioning.rs:123 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 49.582s] datafusion-physical-expr Building datafusion-physical-optimizer v53.1.0 (current) Built [ 36.257s] (current) Parsing datafusion-physical-optimizer v53.1.0 (current) Parsed [ 0.021s] (current) Building datafusion-physical-optimizer v53.1.0 (baseline) Built [ 35.875s] (baseline) Parsing datafusion-physical-optimizer v53.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-physical-optimizer v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.128s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 73.464s] datafusion-physical-optimizer Building datafusion-physical-plan v53.1.0 (current) Built [ 31.874s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.130s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 32.322s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.122s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.539s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 66.173s] datafusion-physical-plan Building datafusion-proto v53.1.0 (current) Built [ 54.383s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.134s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 54.560s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.133s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.657s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron Failed in: variant PartitionMethod:Range in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:2082 variant PartitionMethod:Range in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:2082 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 112.653s] datafusion-proto Building datafusion-sqllogictest v53.1.0 (current) Built [ 138.067s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 139.278s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.091s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 280.347s] datafusion-sqllogictest ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
