andygrove commented on PR #4091: URL: https://github.com/apache/datafusion-comet/pull/4091#issuecomment-4329671647
> Could conversions like BINARY->Boolean or BINARY->Date also reach this code path? If so, would an allow-list approach (allow only the three valid targets, reject the rest) be more defensive here? Yes, they reach this path and were silently delegated to DataFusion's cast (parses date/boolean strings, returns nulls on failure). Switched to an allow-list in the latest commit: when the source is `Utf8`/`LargeUtf8`/`Binary`/`LargeBinary`, the only permitted targets are the same string/binary types and `Decimal128`/`Decimal256` (the binary-encoded decimal case). The test now also covers boolean, date, and timestamp targets in addition to the numeric cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
