mbutrovich commented on PR #4091: URL: https://github.com/apache/datafusion-comet/pull/4091#issuecomment-4327865153
Thanks @andygrove! I double-checked Spark: the guard matches Spark's `ParquetVectorUpdaterFactory.getUpdater()` for BINARY columns (lines 175-180) and looks correct for the numeric cases. One question: the check rejects specific numeric target types, but Spark's vectorized reader rejects BINARY->anything except String, Binary, and binary-encoded Decimal. Could conversions like BINARY->Boolean or BINARY->Date also reach this code path? If so, would an allow-list approach (allow only the three valid targets, reject the rest) be more defensive here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
