andygrove commented on PR #4091: URL: https://github.com/apache/datafusion-comet/pull/4091#issuecomment-4329671121
> Same question as the other PR, can we catch this earlier? As discussed on #4090: I looked at this and the physical Parquet schema is not available at `CometScanRule` time, so we cannot detect the mismatch before serialization. Catching it in the schema adapter (where we do have the physical and target types) is the earliest practical point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
