adriangb commented on PR #19390: URL: https://github.com/apache/datafusion/pull/19390#issuecomment-4232876700
@alamb @geoffreyclaude I wonder if you have any thoughts on how we can move forward with this. May a high level the tradeoff I see is: - This adds complexity. It’s localized and self contained but still. - This meaningfully improves performance of an important operator Practically speaking I want to get this across the line but I find this hard to review, both because of the size of the diff but also because of the nuance of the implementation. Quite honestly without AI explaining to me some of the more niche branches I’d struggle to grok this or find holes in the logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
