erenavsarogullari opened a new pull request, #21577: URL: https://github.com/apache/datafusion/pull/21577
## Which issue does this PR close? - Closes #21447. ## Rationale for this change **Ref Discussion:** https://github.com/apache/datafusion/pull/21355#discussion_r3035659443 Currently, sqllogictest framework does not support custom datafusion.format.* configs updates and it always runs the tests with default format settings and the results as follows: **Current Behavior:** ``` statement ok SET datafusion.format.date_format = '%d-%m-%Y' query D SELECT DATE '2024-03-15' ---- Returns 2024-03-15 (as default date_format) instead of 15-03-2024. ``` **What is the root-cause of this problem?** The reason is that `sqllogictest` framework needs to be extended in order to uptake `datafusion.format.*` settings by `SessionContext` instead default format settings: https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs#L239 like following expected behavior. This ticket aims to address this improvement and add additional functional coverages for `datafusion.format.*` configs for the custom settings. **Expected Behavior:** ``` statement ok SET datafusion.format.date_format = '%d-%m-%Y' query D SELECT DATE '2024-03-15' ---- 15-03-2024 statement ok RESET datafusion.format.date_format query D SELECT DATE '2024-03-15' ---- 2024-03-15 ``` ## What changes are included in this PR? This PR extends `sqllogictest` framework to uptake custom `datafusion.format.*` settings and adds comprehensive test coverage for `datafusion.format.*` configurations. ## Are these changes tested? Yes, by adding comprehensive test coverage for `datafusion.format.*` configurations. ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
