On Tuesday 02 October 2007, Roy Marples wrote: > On Mon, 2007-10-01 at 20:22 -0400, Mike Frysinger wrote: > > i'd say that changing > > things from doing a case match against proper character classes to doing > > a printf against arbitrary character ranges (which btw are not locale > > safe, so i imagine you've introduced a regression there) is not "better". > > but i'm not the maintainer of said eclass. > > That is why the case match is like so > > [0-9] Should be safe - every language should operate in base 10 > -|.|_ Exact match > * If it's not the above, treat it like a letter > > So there shouldn't be any regressions with version numbers here as I've > cunningly avoided the locale trap.
sorry, you're right ... i thought i saw a [A-Z] in there, but it was probably that the old one used [:alpha:] that said, there's no reason to change [[:digit:]] to [0-9] ... using proper character classes is preferred over custom rangers regardless -mike
signature.asc
Description: This is a digitally signed message part.
