On Monday 01 October 2007, Roy Marples wrote: > On Monday 01 October 2007 23:41:36 Fernando J. Pereda wrote: > > I sure as hell am not going to proof read all that (mainly because I > > think not using bash features in an environment where bash is required > > is silly, instead of being an improvement) > > OK. Maybe I shouldn't have mentioned the "in sh" bit. > If I re-submit stuff and just claim better readability and less code you'll > read it then?
"better readability" is a pretty subjective claim ... i'd say that changing things from doing a case match against proper character classes to doing a printf against arbitrary character ranges (which btw are not locale safe, so i imagine you've introduced a regression there) is not "better". but i'm not the maintainer of said eclass. > > but I find interesting that > > you ripped Ciaran's copyright while leaving the "Prod ciaranm if you > > find something it can't handle" comment. > > I copied and pasted the comments for the most part. Sorry for leaving that > bit in. And I thought that the Gentoo Foundation had the copyright? it does. and if it doesnt, punt the file and rewrite it from scratch. -mike
signature.asc
Description: This is a digitally signed message part.
