[gentoo-commits] proj/portage-utils:master commit in: /

[Fabian Groffen]

commit:     d99cc22a91b06d53cc3ef3ff159f25c71d62e750
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Wed Jan 22 19:49:59 2020 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Wed Jan 22 19:49:59 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=d99cc22a

qpkg: fix Coverity 125923 Resource leak

Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 qpkg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/qpkg.c b/qpkg.c
index 7835cd7..948d564 100644
--- a/qpkg.c
+++ b/qpkg.c
@@ -198,18 +198,21 @@ qpkg_make(depend_atom *atom)
 
        snprintf(tmpdir, sizeof(tmpdir), "%s/qpkg.XXXXXX", qpkg_bindir);
        if ((i = mkstemp(tmpdir)) == -1) {
+               fclose(fp);
                free(buf);
                return -2;
        }
        close(i);
        unlink(tmpdir);
        if (mkdir(tmpdir, 0750)) {
+               fclose(fp);
                free(buf);
                return -3;
        }
 
        snprintf(filelist, sizeof(filelist), "%s/filelist", tmpdir);
        if ((out = fopen(filelist, "w")) == NULL) {
+               fclose(fp);
                free(buf);
                return -4;
        }