[gentoo-commits] proj/portage-utils:master commit in: /

[Fabian Groffen]

commit:     70cf788ec5d4f493c099c34c28fb5fdabcd91eac
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Mon Jan 20 19:37:33 2020 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Mon Jan 20 19:37:33 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=70cf788e

qtegrity: fix Coverity 185976 Dereference before null check

Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 qtegrity.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/qtegrity.c b/qtegrity.c
index 0d23a7f..c2fc221 100644
--- a/qtegrity.c
+++ b/qtegrity.c
@@ -306,14 +306,13 @@ int qtegrity_main(int argc, char **argv)
                        get_digest_from_line(buffered_line, recorded_digest,
                                        recorded_digest_size, 50);
 
-                       if (recorded_fname == NULL || recorded_digest == NULL) {
+                       if (recorded_fname == NULL || *recorded_digest == '\0') 
{
                                printf("Empty recorded filename: %s\n", line);
 
                                if (recorded_fname != NULL)
                                        free(recorded_fname);
 
-                               if (recorded_digest != NULL)
-                                       free(recorded_digest);
+                               free(recorded_digest);
 
                                continue;
                        }