commit:     9bcc67d7155a2fa2287d1f2600d3ca2419b51e09
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Wed Jan 22 20:05:57 2020 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Wed Jan 22 20:05:57 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=9bcc67d7

qmanifest: fix Coverity 206530 Explicit null dereferenced

Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 qmanifest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/qmanifest.c b/qmanifest.c
index bead1c9..31c4696 100644
--- a/qmanifest.c
+++ b/qmanifest.c
@@ -1489,7 +1489,8 @@ verify_manifest(
         * - Manifest at top-level, needs to be igored as it only points to
         *   the larger Manifest.files.gz
         */
-       qsort(elems, elemslen, sizeof(elems[0]), compare_elems);
+       if (compare_elems > 1)
+               qsort(elems, elemslen, sizeof(elems[0]), compare_elems);
        snprintf(buf, sizeof(buf), "%s/%s", dir, manifest);
        ret = verify_dir(dir, elems, elemslen, 0, buf + 2, msgs);
        checked_manifests++;

Reply via email to