[gentoo-commits] proj/portage-utils:master commit in: /

[Fabian Groffen]

commit:     84559890f05ae01e3360922c05cafca2fa8d23ea
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Sun Jan 19 18:06:37 2020 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Sun Jan 19 18:06:37 2020 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=84559890

qdepends: fix Coverity 206553 Logically dead code

Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 qdepends.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/qdepends.c b/qdepends.c
index 6f580a9..865605e 100644
--- a/qdepends.c
+++ b/qdepends.c
@@ -162,7 +162,7 @@ qdepends_results_cb(tree_pkg_ctx *pkg_ctx, void *priv)
                depstr = i == 1<<0 ? tree_pkg_meta_get(pkg_ctx, DEPEND) :
                                 i == 1<<1 ? tree_pkg_meta_get(pkg_ctx, 
RDEPEND) :
                                 i == 1<<2 ? tree_pkg_meta_get(pkg_ctx, 
PDEPEND) :
-                                i == 1<<3 ? tree_pkg_meta_get(pkg_ctx, 
BDEPEND) : NULL;
+                                            tree_pkg_meta_get(pkg_ctx, 
BDEPEND);
                if (depstr == NULL)
                        continue;
                dep_tree = dep_grow_tree(depstr);
@@ -180,8 +180,7 @@ qdepends_results_cb(tree_pkg_ctx *pkg_ctx, void *priv)
                                        depstr = i == 1<<0 ? 
tree_pkg_meta_get(vpkg, DEPEND) :
                                                         i == 1<<1 ? 
tree_pkg_meta_get(vpkg, RDEPEND) :
                                                         i == 1<<2 ? 
tree_pkg_meta_get(vpkg, PDEPEND) :
-                                                        i == 1<<3 ? 
tree_pkg_meta_get(vpkg, BDEPEND) :
-                                                        NULL;
+                                                                    
tree_pkg_meta_get(vpkg, BDEPEND);
                                        if (depstr != NULL) {
                                                dep_node *dep_vdb = 
dep_grow_tree(depstr);
                                                if (dep_vdb != NULL)