+1 Triple-checked: LICENSE, DISCLAIMER, license headers, mvn test
I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking for a .git directory. On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes fine > - DISCLAIMER exists and uses the WIP text. you also might want to fill in > #Podling-Name# > - LICENSE is OK. Do you know what is missing? > - NOTICE is fine > - NO binary files in release > - All source files have ASF header > - Can compile from source > > There’s some very minor issues: > - I assume that some of the files may have an incorrect header? > [1][2][3][4][6][7][8]. 3rd party headers should probably not be replaced > with ASF ones [9] unless they have been extensively modified. This shod be > mentioned in the DISCLAIMER. > - In LICENSE there is probably no need to mention the java files that use > the Gettysburg address. > - "lee...@users.noreply.github.com” is probably not the best email to > sign the release with, please use an apache one in future. > - It’s nicer if the source unzips into a directory > > Thanks, > Justin > > 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java > 2. src/main/java/org/apache/datasketches/memory/XxHash64.java > 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java > 4. src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java > 5. src/main/java/org/apache/datasketches/memory/Utf8.java > 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java > 7 src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java > 8 src/main/java/org/apache/datasketches/memory/XxHash64.java > 9 https://www.apache.org/legal/src-headers.html#3party > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
