+1 - code compiles - incubating in name - LICENSE, NOTICE is fine - No unexpected binary files
Thanks, William On Tue, Aug 20, 2019 at 10:30 PM Roman Leventov <leventov...@gmail.com> wrote: > +1 > > On Tue, 20 Aug 2019 at 17:05, Furkan KAMACI <furkankam...@gmail.com> > wrote: > > > Hi, > > > > +1 from me. > > > > I checked: > > > > - Incubating in name > > - LICENSE is fine > > - NOTICE is fine > > - No unexpected binary files > > - Code compiles and tests successfully run > > > > One objection: DISCLAIMER file should be renamed to DISCLAIMER-WIP and > link > > at content should point to datasketches. > > > > Kind Regards, > > Furkan KAMACI > > > > On Mon, Aug 19, 2019 at 11:46 PM leerho <lee...@gmail.com> wrote: > > > > > Hello Apache DataSketches IPMC and Community, > > > > > > 1. This is a call for vote to release Apache DataSketches-memory > version: > > > 1.1.0-incubating-RC2 > > > > > > NOTE 1: This is one component of the DataSketches library that provides > > > high-performance access > > > to off-heap memory for Java applications. These are low-level functions > > > that are used by other > > > DataSketches components. It does not provide any command-line interface > > or > > > GUI. > > > > > > NOTE 2: This release contains some critical performance improvements > for > > > Apache Druid. > > > > > > NOTE 3: This particular component has been split out from the rest of > the > > > DataSketches > > > code because there have been a number of requests from platform > projects > > > that are interested in > > > these high-performance functions independently of the remainder of the > > > DataSketches library. > > > > > > NOTE 4: This RC2 fixes some problems in the structure of the POM file > of > > > RC1. There are no other changes. > > > > > > A. Results from the PPMC vote (open for 140 hours (including the > > > weekend)) > > > > > > - 3 votes were cast. All of the votes were (+1). Two of the votes > > were > > > from Mentors. > > > > > > - The vote thread can be found at: > > > > > > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > > > > > > > B. Testing/actions/votes performed by the voters: > > > > > > - Gian Merlino: (+1) > > > - .asc and .sha512 look good. > > > - git.properties looks good. > > > - Ran "mvn package" without issue. > > > - Source tarball contents match the tag. > > > > > > Gian made several suggestions for improvements for next > release: > > > - have the zip unpack in its own directory not the current > > > directory > > > - DISCLAMER > > > - should be renamed DISCLAMER-WIP > > > - links to > > > http://incubator.apache.org/project/#Podling-Name#.html, but it should > > be > > > https://incubator.apache.org/projects/datasketches.html. > > > (fill in project name, > > > 'projects' instead of 'project', http would work but > https > > > is nicer.) > > > - Vote procedure: > > > - Clarify sentence to require not just 3 (+1) votes, but a > > > majority of (+1s) vs (-1s). > > > - When cancelling a vote use subject [CANCEL][VOTE] ... > > > > > > - Liang Chen (+1 binding) > > > - no comments > > > > > > - Furkan Kamaci (+1 binding) > > > - Incubating in name > > > - LICENSE is fine > > > - NOTICE is fine > > > - No unexpected binary files > > > - Code compiles and tests successfully run > > > - One objection: DISCLAIMER file should be renamed to > > DISCLAIMER-WIP > > > and link > > > at content should point to datasketches. > > > > > > 2. The release candidate: > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.1.0-incubating-RC1/apache-datasketches-memory-1.1.0-incubating-src.zip > > > > > > 3. Source repository: > > > https://github.com/apache/incubator-datasketches-memory > > > > > > Git Tag for this release: > > > > > > > > > https://github.com/apache/incubator-datasketches-memory/tree/1.1.0-incubating-RC1 > > > on branch 1.1.X-incubating > > > > > > Git HashId for this release starts with: 32de195 > > > > > > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > > > > > > 4. Repository: dist.apache.org repository: > > > > > > The public signing key can be found in the KEYS file: > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > > > > > 5. Repository: Maven Central (repository.apache.org): > > > > > > The Jar artifacts can be found at > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/1.1.0-incubating/ > > > > > > 6. Build & Test Guide: > > > > > > The DataSketches-memory component is pure Java and is structured as a > > > Maven project. You must compile using JDK 8. > > > There is one run-time dependency for logging and, of course, a number > of > > > test and Maven plugin dependencies, > > > all of which can be resolved by Maven. > > > > > > There are two types of tests: normal unit tests and tests run by the > > > strict profile. To run normal unit tests: > > > > > > $ mvn clean test > > > > > > To run the strict profile tests: > > > > > > $ mvn clean test -P strict > > > > > > To install jars in your local .m2 repository: > > > > > > $ mvn clean install > > > > > > 7. Documentation: The documentation for the DataSketches Memory > component > > > is part of the website. > > > > > > Overview documentation: > > > - https://datasketches.github.io/docs/Memory/MemoryPackage.html > > > - https://datasketches.github.io/docs/Memory/MemoryPerformance.html > > > > > > Javadocs: > > > - > https://datasketches.github.io/api/memory/snapshot/apidocs/index.html > > > > > > 8. This vote is the 2nd stage vote: > > > - This voting process will remain open for at least 72 hours > > > and until at least 3 (+1) IPMC votes or a majority of (+1) are > > > acquired. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thanks, > > > Lee Rhodes > > > lee...@apache.org > > > > > >
