On 07/03/2013 03:17 PM, Paolo Carlini wrote:
In the first try, bailing out early in case of error without undoing the committed changes to decl1 made me a little nervous. The below variant works at first on newdecl and only if push_template_decl goes well, copies it back to decl1. Still passes testing on x86_64-linux.
Since newdecl points to the same tree node as decl1, I don't see what difference this would make. And I'm not too worried about making changes to a decl that's erroneous anyway.
Your earlier patch, plus removing the FIXME, is OK. Jason