On Mon, May 6, 2013 at 12:01 PM, Jakub Jelinek <ja...@redhat.com> wrote:
> On Mon, Apr 29, 2013 at 01:42:55PM +0200, Jakub Jelinek wrote:
>> On Mon, Apr 29, 2013 at 03:39:58PM +0400, Maksim Kuznetsov wrote:
>> > 2013/4/29 Jakub Jelinek <ja...@redhat.com>:
>> > > Also, why are you handling just %{ and %}, and
>> > > not also %| ? I mean, if you want to print say {|} into assembly for
>> > > both
>> > > dialects, don't you need:
>> > > asm ("{dialect1%{%|%}|%{%|%}dialect2}");
>> > > or similar? If you use just | instead of %|, it would be handled as
>> > > separator of the dialects.
>> >
>> > Sure. %| was removed due to concerns over some target architectures
>> > already use it, but now %| is under ASSEMBLER_DIALECT and doesn't seem
>> > to affect them.
>> >
>> > ChangeLog:
>> >
>> > 2013-04-29 Maxim Kuznetsov <maks.kuznet...@gmail.com>
>> > * final.c (do_assembler_dialects): Don't handle curly braces and
>> > vertical bar escaped by % as dialect delimiters.
>> > (output_asm_insn): Print curly braces and vertical bar if escaped
>> > by % and ASSEMBLER_DIALECT defined.
>> > * doc/tm.texi (ASSEMBLER_DIALECT): Document new standard escapes.
>> >
>> > testsuite/ChangeLog:
>> >
>> > 2013-04-29 Maxim Kuznetsov <maks.kuznet...@gmail.com>
>> >
>> > * gcc.target/i386/asm-dialect-2.c: New testcase.
>>
>> Ok, thanks.
>
> I've noticed this hasn't been applied yet; if you don't have SVN access, you
> need to mention it explicitly, or is there other reason why it hasn't been
> committed?
>
> Jakub
I checked it in for him with a small change in document. It
should be `|' instead of '@|'.
Thanks.
--
H.J.
