Just a comment about tsan. Today, tsan works *only* on x86_64 linux (no 32-bits, no non-linux). Other 64-bit platforms may be doable, but not as easy as for asan. Non-linux is harder than non-x86_64 (need to support tons of libc interceptors). 32-bit platforms are very hard to port to, I would not bother for now. (this probably includes x32, which has cheap atomic 64-bit loads/stores, but has too small address space for tsan)
Conclusion: when committing tsan code, please make sure it is enable only on x86_64 --kcc On Sat, Nov 17, 2012 at 3:13 AM, Wei Mi <w...@google.com> wrote: > Hi, > > Is it ok for the trunk? > > Thanks, > Wei. > > On Tue, Nov 13, 2012 at 5:06 PM, Wei Mi <w...@google.com> wrote: >> Thanks for catching this. I update the patch. >> >> Regards, >> Wei. >> >> On Tue, Nov 13, 2012 at 4:54 PM, Richard Henderson <r...@redhat.com> wrote: >>> On 11/13/2012 04:08 PM, Wei Mi wrote: >>>> +extern void tsan_finish_file (void); >>>> + >>>> +#endif /* TREE_TSAN */ >>>> +/* ThreadSanitizer, a data race detector. >>>> + Copyright (C) 2011 Free Software Foundation, Inc. >>>> + Contributed by Dmitry Vyukov <dvyu...@google.com> >>> >>> Careful, you've got double applied patches there. >>> >>> >>> r~
