On Thu, Nov 22, 2012 at 8:20 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Thu, Nov 22, 2012 at 10:54:00AM +0100, Jakub Jelinek wrote: >> Ok, thanks. The comments can be fixed up incrementally. > > I had closer look at the libsanitizer/tsan configury, and I think I'd prefer > the configure.tgt script to say if tsan should be built or not. > Furthermore, GCC doesn't support -Wno-c99-extensions flag for C++, that is a > clang-ism. > Ok for trunk (after the tsan patches are committed, on top of them)? > > 2012-11-22 Jakub Jelinek <ja...@redhat.com> > > * tsan/Makefile.am (AM_CXXFLAGS): Remove -Wno-variadic-macros. > * Makefile.am (SUBDIRS): Guard tsan addition with TSAN_SUPPORTED > automake conditional instead of !MULTISUBDIR32. > * configure.tgt: Set TSAN_SUPPORTED=yes for x86_64/i686-linux > for 64-bit multilib. > * configure.ac: Check for void * size, source in configure.tgt, > define TSAN_SUPPORTED conditional instead of MULTILIBDIR32. > * configure: Regenerated. > * Makefile.in: Regenerated. > * tsan/Makefile.in: Regenerated.
This is fine if bootstraps succeeds on i686. Diego.
