On Tue, Nov 13, 2012 at 9:36 AM, Jakub Jelinek <[email protected]> wrote: > On Tue, Nov 13, 2012 at 09:25:36AM -0800, Xinliang David Li wrote: >> > That is complete misunderstanding of what update_address_taken does. >> > It removes TREE_ADDRESSABLE from addressables that are no longer >> > addressable, rather than adding TREE_ADDRESSABLE bits. >> >> It will do the latter too. See iv-opts. > > Where? I strongly doubt that.
You are right. iv-opts is probably a good example that the update_stmt can do the right job. thanks, David > >> > For the latter >> > there is mark_addressable function. >> >> This is certainly cheaper to use. > > Even cheaper is just do nothing, tree-ssa-operands.c during > update_stmt_operands (which will be called for all newly created stmts, > upon update_stmt etc.) will take care of calling mark_address_taken. > > Jakub
