Hi Chung-Lin!
On 2026-06-30T15:14:27+0200, I wrote:
> Fix-up for commit 7a8f98b48104ccf10c6dceccc51b70de69288eaa
> "OpenMP: support for uses_allocators clause".
> I see:
>
> {+PASS: libgomp.c++/../libgomp.c-c++-common/uses_allocators-2.c (test
> for errors, line 9)+}
> {+FAIL: libgomp.c++/../libgomp.c-c++-common/uses_allocators-2.c (test for
> excess errors)+}
>
> ..., due to:
>
> [...]/libgomp.c++/../libgomp.c-c++-common/uses_allocators-2.c:7:34:
> error: invalid conversion from 'int' to 'omp_alloctrait_key_t' [-fpermissive]
> [...]/libgomp.c++/../libgomp.c-c++-common/uses_allocators-2.c:16:40:
> error: invalid conversion from 'int' to 'omp_alloctrait_key_t' [-fpermissive]
>
> Replaced '1' by 'omp_atk_sync_hint'.
I hope that was the correct fix?
> I see:
>
> PASS: libgomp.fortran/uses_allocators-7.f90 -O (test for excess errors)
> {+PASS: libgomp.fortran/uses_allocators-7.f90 -O execution test+}
> {+PASS: libgomp.fortran/uses_allocators-7.f90 -O scan-tree-dump-times
> gimple "#pragma omp target .*uses_allocators\\(memspace\\(\\),
> traits\\(trait\\) : my_alloc\\)" 1+}
> {+PASS: libgomp.fortran/uses_allocators-7.f90 -O scan-tree-dump-times
> gimple "#pragma omp target .*uses_allocators\\(memspace\\(\\), traits\\(\\) :
> my_alloc\\)" 1+}
> {+FAIL: libgomp.fortran/uses_allocators-7.f90 -O scan-tree-dump-times
> original "#pragma omp target .*uses_allocators\\(memspace\\(1\\),
> traits\\(\\) : my4\\) uses_allocators\\(memspace\\(\\), traits\\(t2\\) :
> my3\\) uses_allocators\\(memspace\\(\\), traits\\(\\) : my2\\)
> uses_allocators\\(memspace\\(3\\), traits\\(t\\) : my\\)" 1+}
>
> XFAILed (for now.)
Please look into that one.
And, another one, seen with '-m32' testing:
{+PASS: libgomp.fortran/uses_allocators-1.f90 -O (test for warnings,
line 15)+}
{+FAIL: libgomp.fortran/uses_allocators-1.f90 -O (test for excess
errors)+}
[...]/libgomp.fortran/uses_allocators-1.f90:13:4: Error: Type mismatch in
argument 'allocator' at (1); passed INTEGER(8) to INTEGER(4)
Do we just need to fix up the test case, or is there any implementation
work to be done?
Grüße
Thomas
