Hi, On Thu, Jun 25, 2026 at 10:41:42PM +0200, Tobias Burnus wrote: > Chung-Lin Tang wrote: > >This patch is v3 of uses_allocators support. > > Looks mostly good to me – however, as the commit hook > would tell you (or as > ./contrib/gcc-changelog/git_check_commit.py -p -v > reports): > > ERR: unchanged file mentioned in a ChangeLog (did you mean > "gcc/fortran/trans-openmp.cc"?): "gcc/fortran/types.def" > (answer: no, trans-types.cc is already listed; but types.def is nonetheless > wrong.) > > ERR: changed file not mentioned in a ChangeLog: > "gcc/testsuite/c-c++-common/gomp/uses_allocators-2.c" > ERR: changed file not mentioned in a ChangeLog: > "gcc/testsuite/c-c++-common/gomp/uses_allocators-7.c" > ERR: changed file not mentioned in a ChangeLog: > "gcc/testsuite/c-c++-common/gomp/uses_allocators-8.c" > ERR: changed file not mentioned in a ChangeLog: > "gcc/testsuite/g++.dg/gomp/uses_allocators-1.C" > ERR: changed file not mentioned in a ChangeLog: > "libgomp/testsuite/libgomp.fortran/uses_allocators_1.f90" > ERR: changed file not mentioned in a ChangeLog: > "libgomp/testsuite/libgomp.fortran/uses_allocators_2.f90" > > Once you fixed that part: LGTM.
One more small issue. This changes libgomp/configure.ac and regenerates configure, but doesn't regenerate libgomp/config.h.in causing the gcc-autoregen buildbot to fail: diff --git a/libgomp/config.h.in b/libgomp/config.h.in index 46d3eac1e61..0522c50d34a 100644 --- a/libgomp/config.h.in +++ b/libgomp/config.h.in @@ -133,6 +133,9 @@ /* Define to 1 if building libgomp for an accelerator-only target. */ #undef LIBGOMP_OFFLOADED_ONLY +/* Define to 1 if building libgomp for a offload host */ +#undef LIBGOMP_OFFLOAD_HOST + /* Define to 1 if libgomp should use POSIX threads. */ #undef LIBGOMP_USE_PTHREADS https://builder.sourceware.org/buildbot/#/builders/gcc-autoregen If you could fix that up, that would be great. Thanks, Mark
