Chung-Lin Tang wrote:
This patch is v3 of uses_allocators support.
Looks mostly good to me – however, as the commit hook would tell you (or as ./contrib/gcc-changelog/git_check_commit.py -p -v reports): ERR: unchanged file mentioned in a ChangeLog (did you mean "gcc/fortran/trans-openmp.cc"?): "gcc/fortran/types.def" (answer: no, trans-types.cc is already listed; but types.def is nonetheless wrong.) ERR: changed file not mentioned in a ChangeLog: "gcc/testsuite/c-c++-common/gomp/uses_allocators-2.c" ERR: changed file not mentioned in a ChangeLog: "gcc/testsuite/c-c++-common/gomp/uses_allocators-7.c" ERR: changed file not mentioned in a ChangeLog: "gcc/testsuite/c-c++-common/gomp/uses_allocators-8.c" ERR: changed file not mentioned in a ChangeLog: "gcc/testsuite/g++.dg/gomp/uses_allocators-1.C" ERR: changed file not mentioned in a ChangeLog: "libgomp/testsuite/libgomp.fortran/uses_allocators_1.f90" ERR: changed file not mentioned in a ChangeLog: "libgomp/testsuite/libgomp.fortran/uses_allocators_2.f90" Once you fixed that part: LGTM. Thanks for the patch! Tobias
