> It's not really a big deal but at least a bit surprising. If it's just that > then pre-approved.
Thanks Robin, I will rename it and commit if no surprise from test. Pan -----Original Message----- From: Robin Dapp <[email protected]> Sent: Thursday, September 4, 2025 8:34 PM To: Li, Pan2 <[email protected]>; Robin Dapp <[email protected]>; [email protected] Cc: [email protected]; [email protected]; [email protected]; Chen, Ken <[email protected]>; Liu, Hongtao <[email protected]>; Robin Dapp <[email protected]> Subject: Re: [PATCH v1 1/4] RISC-V: Combine vec_duplicate + vmadd.vv to vmadd.vx on GR2VR cost >> So before we had vmacc_vx and now madd can be included. Is this somehow >> different to pred_mul_plus (without vx)? "mul then plus" sounds like there >> is some operand order that differs from the regular order but the >> multiplication is always first IIRC? The difference is just which operand >> is >> being overwritten. > > It is the same as pred_mul_plus without vx, seems we need to take the > mul_plus for vx too. It's not really a big deal but at least a bit surprising. If it's just that then pre-approved. -- Regards Robin
