Should be git diff issue, I notice this before send it out.
Yeah, not your fault, and it's still legible. I was just surprised.
The madd and macc can merged into one combine define_expand as well as define_insn, so rename it to mul_then_plus (and add madd part for define_insn) to indicate the correct sematics.
So before we had vmacc_vx and now madd can be included. Is this somehow different to pred_mul_plus (without vx)? "mul then plus" sounds like there is some operand order that differs from the regular order but the multiplication is always first IIRC? The difference is just which operand is being overwritten.
-- Regards Robin
