On Fri, 9 May 2025, Alejandro Colomar wrote: > Hi Joseph, > > On Fri, May 09, 2025 at 09:00:58PM +0000, Joseph Myers wrote: > > On Fri, 9 May 2025, Alejandro Colomar wrote: > > > > > contrib/ChangeLog: > > > > > > * gcc-changelog/git_commit.py (GitCommit): > > > Add support for 'Cc: ' and 'Link: ' tags. > > > > Please remove this patch from this patch series; it has nothing to do with > > _Countof and would probably be reviewed by different people. > > Who should review that? Nobody applied it, nor replied to it. (IIRC
Putting a patch in an unrelated series makes it *less* likely anyone will look at it, since people concerned with that patch may be disjoint from those concerned with the apparent subject of the series. (So if a change to one part of the compiler depends on a change to another, I think it's always better to post the dependency separately, not as part of the main series.) > someone said the patch looks good, but not someone who should merge it, > so it was of no use.) Please point me to the people who are responsible > for that. People who have worked on that code lately? (In practice people can maintain their own scripts in contrib/, but Martin Liska is no longer significantly active in GCC development so that doesn't help here.) > I disagree. In projects I (co-)maintain, this info has been very > useful, for example to ask about a very old patch, where I couldn't > reach the author, but I could reach people that was CCd in discussions > leading to the patch. Thanks to having their names in commit messages, > I could reach them. > > But since you're the maintainer here, it's your prerrogative, so I can > drop them if you confirm I should do that. I think CC should be dropped from commit messages. -- Joseph S. Myers josmy...@redhat.com
