Richard Biener <rguent...@suse.de> writes:
> On Fri, 13 Nov 2020, Joel Hutton wrote:
>
>> Tests are still running, but I believe I've addressed all the comments.
>>
>> > > +#include <string.h>
>> > > +
>> >
>> > SVE targets will need a:
>> >
>> > #pragma GCC target "+nosve"
>> >
>> > here, since we'll generate different code for SVE.
>>
>> Fixed.
>>
>> > > +/* { dg-final { scan-assembler-times "shll\t" 1} } */
>> > > +/* { dg-final { scan-assembler-times "shll2\t" 1} } */
>> >
>> > Very minor nit, sorry, but I think:
>> >
>> > /* { dg-final { scan-assembler-times {\tshll\t} 1 } } */
>> >
>> > would be better. Using "?\t" works, but IIRC it shows up as a tab
>> > character in the testsuite result summary too.
>>
>> Fixed. Minor nits welcome. :)
>>
>>
>> > OK for the aarch64 bits with the testsuite changes above.
>> ok?
>
> The gcc/tree-vect-stmts.c parts are OK.
Same for the AArch64 stuff.
Thanks,
Richard
