On Tue, May 19, 2020 at 4:17 AM H.J. Lu <hjl.to...@gmail.com> wrote:
>
> On Mon, May 18, 2020 at 5:57 AM H.J. Lu <hjl.to...@gmail.com> wrote:
> >
> > On Mon, May 18, 2020 at 5:43 AM Uros Bizjak <ubiz...@gmail.com> wrote:
> > >
> > > On Mon, May 18, 2020 at 2:34 PM H.J. Lu <hjl.to...@gmail.com> wrote:
> > > >
> > > > On Mon, May 18, 2020 at 5:18 AM Uros Bizjak <ubiz...@gmail.com> wrote:
> > > > >
> > > > > On Mon, May 18, 2020 at 1:58 PM H.J. Lu <hjl.to...@gmail.com> wrote:
> > > > > >
> > > > > > Add cpu model numbers for Intel Airmont, Tremont, Comet Lake, Ice 
> > > > > > Lake
> > > > > > and Tiger Lake processor families.
> > > > > >
> > > > > > OK for master?
> > > > >
> > > > > OK.
> > > >
> > > > I am checking in my patch.
> > > >
> > > > > Please also update cpuinfo.c from libgcc and corresponding
> > > >
> > > > I will take a look to see if we share the same CPU detection code 
> > > > between
> > > > libgcc and config/i386/driver-i386.c.
> > >
> > > I don't think it will bring any benefit, this is mainly one huge
> > > switch statement that maps to different stuff in libgcc and
> > > driver-i386.
> >
> > libgcc and config/i386/driver-i386.c differ even before my patch.
> > I think we can do better.
> >
>
> Move cpuinfo.h from libgcc to common/config/i386 so that get_intel_cpu
> can be shared by libgcc, GCC driver, gcc.target/i386/builtin_target.c
> and libgfortran to detect the specific type of Intel CPU.  Update
> libgfortran to use has_cpu_feature to detect x86 CPU features.
>
> Tested on Linux/x86 and Linux/x86-64.  OK for master?

Handling only Intel targets and not others is a sure way for patch to
be ignored.

Uros.

Reply via email to