On Thu, May 02, 2019 at 09:37:36AM +0200, Iain Buclaw wrote:
> > libphobos/
> > * std/math.d (IeeeFlags.getIeeeFlags): Handle RISC-V soft-float
> > ABI.
> > (IeeeFlags.resetIeeeFlags): Likewise.
> > (FloatingPointControl.getControlState): Likewise.
> > (FloatingPointControl.setControlState): Likewise.
> > I believe this change is obviously correct, and I also verified generated
> > code using `objdump -d'. I have no way to regression-test it right now.
> >
> > Please confirm if I correctly referred to identifiers in the ChangeLog
> > entry though, as my experience WRT the D programming language and its
> > syntax in particular is nil.
> >
> > My understanding is changes to `libphobos' are supposed to go upstream
> > first, but r270522 is a local change anyway AFAICT, and technically a
> > `--enable-languages=all' build regression, so we better fix it ASAP.
> >
> > Finally my WDC copyright assignment with FSF is still in the works, but I
> > believe this change can be considered legally insignificant for copyright
> > purposes, i.e. having at most 15 lines or so, unless adding white space
> > for indentation counts against that limit as well (which I doubt).
> >
> > With all of the above in mind, OK to apply to trunk and to GCC 9?
> >
>
> Looks OK to me.
The change is ok for 9.1 if it can be committed to gcc-9-branch today.
Jakub
