On Tue, Oct 02, 2018 at 08:24:31AM -0500, Aaron Sawdey wrote:
> >> @@ -2205,6 +2205,7 @@
> >> }
> >> else
> >> {
> >> + /* Implies TARGET_P8_VECTOR here. */
> >
> > That isn't true as far as I see.
>
> We can only enter emit_final_str_compare_vec() if TARGET_P8_VECTOR is set.
> That's the additional check this patch adds. So in this function you can have
> both P8 and P9 vector, or just p8 vector. rs6000_option_override_internal()
> enforces that P8 vector must be set if P9 vector is set. So in the else here
> we know that only p8 vector is set.
It's not obvious. Add an assert, maybe? Instead of the comment :-)
Segher
