RE: [PATCH][GCC][front-end][opt-framework] Update options framework for parameters to properly handle and validate configure time params. [Patch (2/3)]

[Alexander Monakov]

Hello,

On Tue, 24 Jul 2018, tamar.christ...@arm.com wrote:
> 
>       * params.c (validate_param): New.
>       (add_params): Use it.
>       (set_param_value): Refactor param validation into validate_param.
>       (diagnostic.h): Include.
>       * diagnostic.h (diagnostic_ready_p): New.

this patch was committed to trunk recently, and an automated email from
Coverity static checker has pointed out a useless self-assignment in a new
loop. It seems wrong indeed.

@@ -68,12 +73,26 @@ add_params (const param_info params[], size_t n)
[...]
+
+  /* Now perform some validation and set the value if it validates.  */
+  for (size_t i = 0; i < n; i++)
+    {
+       if (validate_param (dst_params[i].default_value, dst_params[i], (int)i))
+         dst_params[i].default_value = dst_params[i].default_value;
+    }
 }
 

Alexander