On Thu, 20 Sep 2018 at 16:22, Jonathan Wakely <[email protected]> wrote:
>
> On 20/09/18 15:36 +0200, Christophe Lyon wrote:
> >On Wed, 19 Sep 2018 at 23:13, Rainer Orth <[email protected]>
> >wrote:
> >>
> >> Hi Christophe,
> >>
> >> > I have noticed failures on hypot-long-double.cc on arm, so I suggest we
> >> > add:
> >> >
> >> > diff --git
> >> > a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > index 8a05473..4c2e33b 100644
> >> > ---
> >> > a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > +++
> >> > b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc
> >> > @@ -17,7 +17,7 @@
> >> >
> >> > // { dg-options "-std=gnu++17" }
> >> > // { dg-do run { target c++17 } }
> >> > -// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux*
> >> > nios2-*-* } }
> >> > +// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux*
> >> > nios2-*-* arm*-*-* } }
> >> >
> >> > // Run the long double tests from hypot.cc separately, because they
> >> > fail on a
> >> > // number of targets. See PR libstdc++/78179 for details.
> >> >
> >> > OK?
> >>
> >> just a nit (and not a review): I'd prefer the target list to be sorted
> >> alphabetically, not completely random.
> >>
> >
> >Sure, I can sort the whole list, if OK on principle.
>
> Yes, please go ahead and commit it with the sorted list.
>
OK committed as r264443:
Index: testsuite/26_numerics/headers/cmath/hypot-long-double.cc
===================================================================
--- testsuite/26_numerics/headers/cmath/hypot-long-double.cc (revision 264442)
+++ testsuite/26_numerics/headers/cmath/hypot-long-double.cc (revision 264443)
@@ -17,7 +17,7 @@
// { dg-options "-std=gnu++17" }
// { dg-do run { target c++17 } }
-// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux* nios2-*-* } }
+// { dg-xfail-run-if "PR 78179" { arm*-*-* hppa-*-linux* nios2-*-*
powerpc-ibm-aix* } }
// Run the long double tests from hypot.cc separately, because they fail on a
// number of targets. See PR libstdc++/78179 for details.
