On Mon, 3 Sep 2018 at 16:54, Jonathan Wakely <jwak...@redhat.com> wrote: > > Split the long double testing into a separate file, so that we can XFAIL > targets where the long double precision doesn't meet the expected > tolerances. The float and double tests are still expefted to PASS for > all targets. > > PR libstdc++/78179 > * testsuite/26_numerics/headers/cmath/hypot-long-double.cc: New test > that runs the long double part of hypot.cc. > * testsuite/26_numerics/headers/cmath/hypot.cc: Disable long double > tests unless TEST_HYPOT_LONG_DOUBLE is defined. > > Tested x86_64-linux, committed to trunk. >
Hi, I have noticed failures on hypot-long-double.cc on arm, so I suggest we add: diff --git a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc index 8a05473..4c2e33b 100644 --- a/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc +++ b/libstdc++-v3/testsuite/26_numerics/headers/cmath/hypot-long-double.cc @@ -17,7 +17,7 @@ // { dg-options "-std=gnu++17" } // { dg-do run { target c++17 } } -// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux* nios2-*-* } } +// { dg-xfail-run-if "PR 78179" { powerpc-ibm-aix* hppa-*-linux* nios2-*-* arm*-*-* } } // Run the long double tests from hypot.cc separately, because they fail on a // number of targets. See PR libstdc++/78179 for details. OK? Christophe