Hi Jakub, >>Still missing . at the end of the above line.
The sentence continues on the next line (so the "." is there): +* config/rx/constraints.md (CALL_OP_SYMBOL_REF): Added new constraint +to allow or block "symbol_ref" depending on the value of TARGET_JSR. I think this is OK, please confirm. Best Regards, Sebastian > -----Original Message----- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: 12 February 2018 13:30 > To: Sebastian Perta <sebastian.pe...@renesas.com> > Cc: Nick Clifton <ni...@redhat.com>; gcc-patches <gcc- > patc...@gcc.gnu.org> > Subject: Re: PING [PATCH] RX movsicc degrade fix > > On Mon, Feb 12, 2018 at 01:27:24PM -0000, Sebastian Perta wrote: > > --- ChangeLog(revision 257583) > > +++ ChangeLog(working copy) > > @@ -129,8 +129,7 @@ > > > > 2018-02-09 Sebastian Perta <sebastian.pe...@renesas.com> > > > > -* config/rx.md: updated "movsicc" expand to be matched by GCC > > -* testsuite/gcc.target/rx/movsicc.c: new test case > > +* config/rx/rx.md (movsicc): Update expander to be matched by > GCC. > > > > 2018-02-09 Peter Bergner <berg...@vnet.ibm.com> > > > > @@ -143,10 +142,10 @@ > > > > 2018-02-09 Sebastian Perta <sebastian.pe...@renesas.com> > > > > -* config/rx/constraints.md: added new constraint > CALL_OP_SYMBOL_REF > > -to allow or block "symbol_ref" depending on value of TARGET_JSR > > -* config/rx/rx.md: use CALL_OP_SYMBOL_REF in call_internal and > > -call_value_internal insns > > +* config/rx/constraints.md (CALL_OP_SYMBOL_REF): Added new > constraint > > Still missing . at the end of the above line. > > Otherwise LGTM. > > Jakub Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
